Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle multiple repos in search query #261

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: handle multiple repos in search query #261

merged 1 commit into from
Apr 30, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Apr 30, 2024 •
edited
Loading

Pull Request

fixes #256

Proposed Changes

This pull request includes changes to the issue_metrics.py and test_issue_metrics.py files. The changes are primarily aimed at allowing the search_issues function to search for issues in multiple GitHub repositories at once. This is achieved by modifying the function to accept a list of owners and repositories, instead of a single owner and repository.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@zkoppert zkoppert requested a review from jmeridth as a code owner April 30, 2024 00:12
@github-actions github-actions bot added the fix label Apr 30, 2024
jmeridth
jmeridth approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zkoppert zkoppert merged commit d40d483 into main Apr 30, 2024
31 checks passed
@zkoppert zkoppert deleted the multi-repo-search-queries branch April 30, 2024 17:25
@zkoppert zkoppert mentioned this pull request Oct 23, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeridth jmeridth jmeridth approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to handle multiple repo: inputs in search query
2 participants
@zkoppert @jmeridth